Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need for mark-as-final operation #128

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Conversation

kachayev
Copy link
Collaborator

@kachayev kachayev commented Mar 2, 2024

With #123 being merged the selector does not check if estimator was 'final' in the pipeline. Thus the API for marking is not needed.

@kachayev kachayev added enhancement New feature or request domain-aware api labels Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (4950a16) to head (b863a90).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   91.85%   91.83%   -0.02%     
==========================================
  Files          43       43              
  Lines        3400     3392       -8     
==========================================
- Hits         3123     3115       -8     
  Misses        277      277              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kachayev kachayev merged commit 8a46819 into main Mar 2, 2024
10 checks passed
@kachayev kachayev deleted the fix-remove-final-marking branch March 2, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain-aware api enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant