Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TO_REVIEW] Add utilities functions to the doc #227

Merged
merged 12 commits into from
Sep 5, 2024

Conversation

antoinecollas
Copy link
Collaborator

@antoinecollas antoinecollas commented Sep 4, 2024

Updated Documentation:

  • skada.source_target_split
  • skada.per_domain_split
  • skada.utils.check_X_y_domain
  • skada.utils.extract_source_indices
  • skada.utils.extract_domains_indices
  • skada.utils.source_target_merge

Issue Resolved:
The example for skada.utils.source_target_merge failed when y_target=None because the function was generating y_target with _DEFAULT_MASKED_TARGET_REGRESSION_LABEL, even for classification tasks. This caused a type mismatch when merging arrays (int vs. nan). nan were then casted as int with specific value -9xxxxx.

@antoinecollas antoinecollas changed the title Add utilises functions to the doc Add utilities functions to the doc Sep 4, 2024
@antoinecollas antoinecollas changed the title Add utilities functions to the doc [TO_REVIEW] Add utilities functions to the doc Sep 4, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (3647fd9) to head (133f0dd).
Report is 1 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (3647fd9) and HEAD (133f0dd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3647fd9) HEAD (133f0dd)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #227       +/-   ##
===========================================
- Coverage   97.24%   83.07%   -14.17%     
===========================================
  Files          54       46        -8     
  Lines        5620     5259      -361     
===========================================
- Hits         5465     4369     -1096     
- Misses        155      890      +735     

@antoinecollas antoinecollas merged commit 43c17e9 into scikit-adaptation:main Sep 5, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants