-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TO_REVIEW] Add utilities functions to the doc #227
Merged
antoinecollas
merged 12 commits into
scikit-adaptation:main
from
antoinecollas:doc_utilities
Sep 5, 2024
Merged
[TO_REVIEW] Add utilities functions to the doc #227
antoinecollas
merged 12 commits into
scikit-adaptation:main
from
antoinecollas:doc_utilities
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o doc_utilities
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
===========================================
- Coverage 97.24% 83.07% -14.17%
===========================================
Files 54 46 -8
Lines 5620 5259 -361
===========================================
- Hits 5465 4369 -1096
- Misses 155 890 +735 |
tgnassou
approved these changes
Sep 5, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Documentation:
skada.source_target_split
skada.per_domain_split
skada.utils.check_X_y_domain
skada.utils.extract_source_indices
skada.utils.extract_domains_indices
skada.utils.source_target_merge
Issue Resolved:
The example for
skada.utils.source_target_merge
failed wheny_target=None
because the function was generatingy_target
with_DEFAULT_MASKED_TARGET_REGRESSION_LABEL
, even for classification tasks. This caused a type mismatch when merging arrays (int
vs.nan
).nan
were then casted asint
with specific value-9xxxxx
.