[MRG] Add MCC method #250
Merged
[MRG] Add MCC method #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanisLalou
reviewed
Oct 9, 2024
skada/deep/losses.py
Outdated
|
|
||
| # Uncertainty Reweighting & class correlation matrix | ||
| H = -torch.sum(y_scaled * torch.log(y_scaled), axis=1) | ||
| W = (1 + torch.exp(H)) / torch.mean(1 + torch.exp(H)) |
There was a problem hiding this comment.
Suggested change
| W = (1 + torch.exp(H)) / torch.mean(1 + torch.exp(H)) | |
| W = (1 + torch.exp(-H)) / torch.mean(1 + torch.exp(-H)) |
| C_tilde = C / torch.sum(C, axis=1, keepdim=True) | ||
|
|
||
| # MCC Loss | ||
| C_ = C_tilde - torch.diag(torch.diag(C_tilde)) |
There was a problem hiding this comment.
Suggested change
| C_ = C_tilde - torch.diag(torch.diag(C_tilde)) | |
| C_ = C_tilde - torch.diag(C_tilde) |
There was a problem hiding this comment.
What I want is to remove the diag. If I do only one torch.diag I will have a vector and then remove the diag on all the line. Two torch.diag create a diagonal matrix
There was a problem hiding this comment.
Ah my bad I thought it returned a diagonal matrix directly
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
===========================================
- Coverage 97.33% 81.35% -15.98%
===========================================
Files 56 48 -8
Lines 5845 5373 -472
===========================================
- Hits 5689 4371 -1318
- Misses 156 1002 +846 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.