[MRG] Handle edge case Mixvalscorer #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to handle cases where there are no indices for intra-cluster or inter-cluster evaluations in the
MixValScorer
, and updates the corresponding tests to ensure these cases are properly handled.Handling NaN values in scoring:
skada/metrics.py
: Added checks to setice_same
andice_diff
tonp.nan
if their respective index lists are empty. Modified the calculation ofice_score
to usenp.nanmean
instead of a simple average. [1] [2] [3]Updating tests:
skada/tests/test_scorer.py
: Added aDummyEstimator
class and new test cases to verify thatice_same
andice_diff
are set toNaN
when appropriate, and that the combined score is calculated correctly even when individual scores areNaN
.