[MRG] Add SPA method #276
Merged
[MRG] Add SPA method #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
===========================================
- Coverage 97.10% 77.12% -19.98%
===========================================
Files 61 52 -9
Lines 6382 5924 -458
===========================================
- Hits 6197 4569 -1628
- Misses 185 1355 +1170
|
YanisLalou
reviewed
Nov 18, 2024
skada/deep/_graph_alignment.py
Outdated
Comment on lines
90
to
92
| loss_adv = self.domain_criterion_( | ||
| domain_pred_s, domain_label | ||
| ) + self.domain_criterion_(domain_pred_t, domain_label_target) |
There was a problem hiding this comment.
in eq (1) of the paper, they use both the cross entropy and the modified cross entropy loss (log(1-prob))
There was a problem hiding this comment.
we should also use label smoothing as the code of the paper: https://github.com/CrownX/SPA/blob/main/code/loss.py#L65-L84
|
Nice results with SPA, lets merge this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://arxiv.org/pdf/2310.17594