Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The selector to pass the params to the base estimator #35

Merged
merged 3 commits into from
Dec 8, 2023
Merged

The selector to pass the params to the base estimator #35

merged 3 commits into from
Dec 8, 2023

Conversation

kachayev
Copy link
Collaborator

@kachayev kachayev commented Dec 6, 2023

Closes #34.

rflamary
rflamary approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@rflamary rflamary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kachayev kachayev changed the title [WIP] The selector to pass the params to the base estimator The selector to pass the params to the base estimator Dec 8, 2023
@kachayev kachayev merged commit fe42db9 into main Dec 8, 2023
@kachayev kachayev deleted the fix-selector-params-proxy branch December 8, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rflamary rflamary rflamary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selector to propagate params to the estimators
2 participants
@kachayev @rflamary