Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update flake8.yaml to actually run! #72

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Feb 5, 2024

Now flake8 should run automatically on PR

Now flake8 should run automatically on PR
@rflamary rflamary changed the title Update flake8.yaml to actuallky run! [Fix] Update flake8.yaml to actually run! Feb 5, 2024
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@1f51b04). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage        ?   73.76%           
=======================================
  Files           ?       38           
  Lines           ?     2398           
  Branches        ?        0           
=======================================
  Hits            ?     1769           
  Misses          ?      629           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rflamary rflamary merged commit 5fe1df9 into main Feb 5, 2024
8 of 10 checks passed
YanisLalou pushed a commit to YanisLalou/skada that referenced this pull request Feb 6, 2024
Now flake8 should run automatically on PR
kachayev added a commit that referenced this pull request Feb 20, 2024
* source_target_merge accepts now N dimenstion array + name change + test cases

* wrong import

* Fix + new test cases

* Fix typo

* _merge_arrays() now accepts multiple arrays as input. The len(arrays) should be even

* Removed a modified file from pull request

* Update flake8.yaml to actuallky run! (#72)

Now flake8 should run automatically on PR

* Fix flake8 for utils and tests (#73)

* source_target_merge accepts now N dimenstion array + name change + test cases

* wrong import

* _merge_arrays() now accepts multiple arrays as input. The len(arrays) should be even

* Removed a modified file from pull request

* flake8

* Loop optimisation + Remove redundant raise errors

* Add test case

* confict merge

* flake8

* Change "duo" for "pair" + simplify small things

* Change source_target_merge return type

---------

Co-authored-by: Rémi Flamary <[email protected]>
Co-authored-by: Oleksii Kachaiev <[email protected]>
@rflamary rflamary deleted the rflamary-patch-1 branch February 22, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant