Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] JDOT Regressor #76

Merged
merged 23 commits into from
Feb 16, 2024
Merged

[MRG] JDOT Regressor #76

merged 23 commits into from
Feb 16, 2024

Conversation

rflamary
Copy link
Collaborator

@rflamary rflamary commented Feb 7, 2024

New JDOTRegressor class

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (31ea1b0) 87.31% compared to head (2635f14) 88.04%.

Files Patch % Lines
skada/_ot.py 98.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   87.31%   88.04%   +0.73%     
==========================================
  Files          38       41       +3     
  Lines        2435     2576     +141     
==========================================
+ Hits         2126     2268     +142     
+ Misses        309      308       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kachayev kachayev added the algorithm Implementation or improvements of the DA methods label Feb 7, 2024
@rflamary rflamary changed the title [WIP] JDOT Regressor [Review] JDOT Regressor Feb 9, 2024
@kachayev kachayev self-requested a review February 9, 2024 21:52
@rflamary rflamary requested a review from kachayev February 14, 2024 15:28
@rflamary rflamary changed the title [Review] JDOT Regressor [MRG] JDOT Regressor Feb 14, 2024
@rflamary rflamary merged commit 53a0b92 into main Feb 16, 2024
7 checks passed
@rflamary rflamary deleted the jdotregressor branch February 22, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Implementation or improvements of the DA methods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants