Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove target labels in the method comparison example #92

Merged
merged 3 commits into from
Feb 17, 2024

Conversation

antoinedemathelin
Copy link
Contributor

Hi everyone,
I open this PR to fix a little bug in the plot_method_comparison.py example. Target labels were given to the fit methods, they are now removed (cf. #83).

The reweighting method are still not working, but it should be resolved soon, with PR #90

@kachayev kachayev added bug Something isn't working documentation Improvements or additions to documentation labels Feb 16, 2024
@rflamary
Copy link
Collaborator

rflamary commented Feb 16, 2024

Hello @antoinedemathelin yes this is inetresting. I think we need to modify the calls to the make_shifted_dataset function to return a DomainAwareDataset insteda of recereating one from X,y, sampledomain

@kachayev
Copy link
Collaborator

kachayev commented Feb 16, 2024

Quick suggestion to what @rflamary said: passing return_dataset=True argument to make_shifted_dataset will give you dataset right away.

@antoinedemathelin
Copy link
Contributor Author

Ok, it now uses the return_dataset=True argument, then the dataset API

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b834a66) 88.54% compared to head (c8e5587) 88.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   88.54%   88.50%   -0.04%     
==========================================
  Files          41       41              
  Lines        2601     2601              
==========================================
- Hits         2303     2302       -1     
- Misses        298      299       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kachayev kachayev merged commit 52b63b0 into scikit-adaptation:main Feb 17, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants