Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCEMENT: Avoid if_else_isinstance(Subsample) in regression.py code #124

Closed
tmorzade opened this issue Jan 14, 2022 · 0 comments · Fixed by #125
Closed

ENHANCEMENT: Avoid if_else_isinstance(Subsample) in regression.py code #124

tmorzade opened this issue Jan 14, 2022 · 0 comments · Fixed by #125
Assignees

Comments

@tmorzade
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There are if_else switches according to "cv" value in the regression.py code that make the code unclear and could become more and more cumbersome with new methods.

Describe the solution you'd like
Use the matrix k_ for all methods

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant