Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CQR typing corrections #176

Closed
LacombeLouis opened this issue Jun 15, 2022 · 0 comments
Closed

CQR typing corrections #176

LacombeLouis opened this issue Jun 15, 2022 · 0 comments

Comments

@LacombeLouis
Copy link
Collaborator

Describe the bug
For MapieQuantileRegressor the fit and predict have a # type: ignore for the moment due to typing issues during the implementation. The issue seemed to come from the fact that MapieQuantileRegressor is a child class of MapieRegressor, however, this typing error did not occur in other methods such as time_series_regression.py, so it would interesting to investigate why this occurs of MapieQuantileRegressor.

To Reproduce
Steps to reproduce the behavior:

  1. Go to quantile_regression.py
  2. Scroll to fitor predict and delete the # type: ignore.
  3. Run make type-check in the terminal and you will get the errors mentionned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant