Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification of the "symmetry" argument in CQR and more general documentation about CQR #249

Closed
gmartinonQM opened this issue Jan 5, 2023 · 1 comment · Fixed by #443
Assignees
Milestone

Comments

@gmartinonQM
Copy link
Collaborator

gmartinonQM commented Jan 5, 2023

Hi all, and thanks again for all your developments of MAPIE !

I recently struggled with CQR, wondering what was the impact of the symmetry argument in MapieQuantileRegressor.predict function. The docstring is quite elusive :

"Deciding factor to whether to find the quantile value for each residuals separatly or to use the maximum of the two combined."

(BTW there is a typo on "separatly" -> "separately").

And I cannot find more information, be it in the theoretical description, the tutorial on CQR or the 1D-heteroscedastic example.

Would it be possible to better describe the impact of the argument and to illustrate it in the tutorial for example ?

Moreover, I am not sure that I understand the notations in the theoretical description. For example, there are three different notations E_i, E_{low} and E_{high} but none is defined. As for the vocabulary, I find the word "residual" confusing in the context of CQR, because it suggests that we compute the difference between the target and the main model prediction (the median estimator) whereas we compare with the other two quantiles.

Capture d’écran 2023-01-05 à 22 15 30

Would it be possible to clarify these points ?

Thanks in advance !

@nmdwolf
Copy link

nmdwolf commented Jan 6, 2023

The standard implementation uses the maximum of the lower and upper quantile residuals. However, one could generalize this method to correct the lower and upper quantiles independently (with some correction as to maintain the required significance level). I assume this is what they mean. (I feel like the documentation should be improved and corrected on many levels.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants