Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JOSS Review Suggested Edits #166

Closed
4 tasks done
sauln opened this issue Apr 6, 2019 · 0 comments
Closed
4 tasks done

JOSS Review Suggested Edits #166

sauln opened this issue Apr 6, 2019 · 0 comments
Labels
good first issue

Comments

@sauln
Copy link
Member

sauln commented Apr 6, 2019 •
edited
Loading

Review in openjournals/joss-reviews#1315 by @ixjlyons suggested a few minor fixes along with #164 and #165.

JOSS Paper:

  • Typo in the paper, second paragraph: "We also an provide extensive..." -> "We also provide an extensive..."
  • I think there may be some missing DOIs in the references.

KM implementation:

  • I'd consider hiding SimplicialNerve until it's implemented.
  • The last example in the KeplerMapper.project() docstring should probably be moved/copied to the fit_transform() docstring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sauln