abort_source: modify subscribe method #2264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when subscribe method is called on an abort_source on which abort has already been requested, method's arguments are ignored and std::nullopt is returned. So, behaviour of the method depends on timing and aforementioned case needs to be handled by a caller. If subscribe is called on already aborted abort source, trigger a function passed as an argument.
bhalevy
reviewed
May 22, 2024
| template <typename Func> | ||
| requires (std::is_nothrow_invocable_r_v<void, Func, const std::optional<std::exception_ptr>&> || | ||
| std::is_nothrow_invocable_r_v<void, Func>) | ||
| [[nodiscard]] | ||
| optimized_optional<subscription> subscribe(Func&& f) { | ||
| if (abort_requested()) { | ||
| f(_ex); |
There was a problem hiding this comment.
I'm not sure can make such a semantic change without auditing all call sites.
Are all callers ready to be called back at this early stage?
In some cases this is done in constructors and there could be more initialization taking place after subscribing (even as member initialization)
There was a problem hiding this comment.
Oh, I see, like capturing the object while it isn't fully initialized yet, since constructor is synchronous anyway.
I missed that and the call seemed more intuitive. Closing then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when subscribe method is called on an abort_source on which abort has already been requested, method's arguments are ignored and std::nullopt is returned. So, behaviour of the method depends on timing and aforementioned case needs to be handled by a caller.
If subscribe is called on already aborted abort source, trigger a function passed as an argument.