testing: prevent test scheduling after reactor exit #2644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xemul
reviewed
Feb 17, 2025
src/testing/test_runner.cc
Outdated
| @@ -130,6 +131,11 @@ test_runner::run_sync(std::function<future<>()> task) { | |||
| // it. | |||
| return; | |||
| } | |||
| if (_done) { | |||
There was a problem hiding this comment.
Can it happen that _done is false, but _exit_code is non-zero?
In other words -- is the above if (_exit_code != 0) still required?
There was a problem hiding this comment.
ahh, you're right. with my change, if _done is true, it implies app.run() has returned -- it's an early return, and the return code is either 0 or a non-zero status code. let me update the change to further simplify this implementation.
tchaikov
force-pushed
the
test-exit-on-stop
branch
from
c689479 to
7d20a3d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Previously, when handling "--help" (introduced in b8a13be), we returned status code 0 but continued scheduling test tasks to the Seastar reactor. This caused test applications to hang since the tasks expected the exchanger 'e' to be available after reactor exit. Fix this by using the "_done" flag to track reactor state: - Set "_done" when Seastar application exits - Skip task scheduling and exchanger wait if "_done" is set - Change test_runner::start_thread() to return bool indicating successful engine startup instead of exit code (exit code now stored in _exit_code member) This fixes the regression where "--help" would cause test applications to hang indefinitely. Fixes scylladb#2635 Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
test-exit-on-stop
branch
from
7d20a3d to
5539fd0
Compare
|
v2:
|
tchaikov
force-pushed
the
test-exit-on-stop
branch
from
5539fd0 to
c0370fb
Compare
|
tested with kefu@mega:~/dev/seastar$ build/debug/tests/unit/queue_test -- --help
Running 3 test cases...
WARNING: debug mode. Not for benchmarking or production
App options:
-h [ --help ] show help message
--help-seastar show help message about seastar options
--help-loggers print a list of logger names and exit
--random-seed arg Random number generator seed
--fail-on-abandoned-failed-futures arg (=1)
Fail the test if there are any
abandoned failed futures
*** No errors detected
kefu@mega:~/dev/seastar$ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when handling "--help" (introduced in b8a13be), we returned status code 0 but continued scheduling test tasks to the Seastar reactor. This caused test applications to hang since the tasks expected the exchanger 'e' to be available after reactor exit.
Fix this by using the "_done" flag to track reactor state:
This fixes the regression where "--help" would cause test applications to hang indefinitely.
Fixes #2635
Signed-off-by: Kefu Chai [email protected]