Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change items.py to add float and int #215

Merged
merged 5 commits into from
Aug 2, 2022
Merged

change items.py to add float and int #215

merged 5 commits into from
Aug 2, 2022

Conversation

SamirPS
Copy link
Contributor

@SamirPS SamirPS commented Jul 28, 2022

I change the add method for Integrer and add a test from this issue #214 now it's work but i don't know if you need this

@SamirPS
Copy link
Contributor Author

SamirPS commented Jul 28, 2022

@frostming @abravalheri @sdispater @hukkinj1 @Secrus

frostming
frostming reviewed Jul 28, 2022
View reviewed changes
@SamirPS
Copy link
Contributor Author

SamirPS commented Jul 31, 2022

@frostming

frostming
frostming reviewed Aug 1, 2022
View reviewed changes
@SamirPS @frostming
Update tomlkit/items.py
7763682 
Co-authored-by: Frost Ming <[email protected]>
@SamirPS
Copy link
Contributor Author

SamirPS commented Aug 1, 2022 •
edited
Loading

I add your commit @frostming

@frostming
Copy link
Contributor

frostming commented Aug 1, 2022 •
edited
Loading

I add your commit @frostming

Thanks. As a kind note about open source contribution, don't ping someone with @ but only click the resolve button when you are done with the change. It is a useless noise and will make people feel disturbed.

@SamirPS
Copy link
Contributor Author

SamirPS commented Aug 1, 2022

Sorry i didn't know

@frostming frostming merged commit a639224 into python-poetry:master Aug 2, 2022
@frostming
Copy link
Contributor

Thanks for your contribution.

capuanob pushed a commit to capuanob/tomlkit that referenced this pull request Mar 1, 2023
@SamirPS @frostming
fix: change items.py to add float and int (python-poetry#215)
b37680d 
* change items.py to add float and int

* Update items.py

* Update

* Update tomlkit/items.py

Co-authored-by: Frost Ming <[email protected]>

* run lint

Co-authored-by: Frost Ming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostming frostming frostming left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamirPS @frostming