Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated methods #102

Closed
seejohnrun opened this issue Oct 12, 2012 · 4 comments
Closed

Remove deprecated methods #102

seejohnrun opened this issue Oct 12, 2012 · 4 comments
Assignees

Comments

@seejohnrun
Copy link
Collaborator

No description provided.

@avit
Copy link
Collaborator

avit commented Dec 2, 2012

to_hash also outputs a :start_date key. Should these be changed to :start_time for consistency?

@jessereynolds
Copy link

I have the same question. When looking at the to_hash output (or to_yaml) it seems odd that we have start_date and end_time. I think consistency here would be great. But perhaps there's a reason they're different?

      {
        "start_date": "2013-01-28 08:00:00 +1030",
        "end_time": "2013-01-28 18:00:00 +1030"
      }

@seejohnrun
Copy link
Collaborator Author

I think we need to move to start_time. The only reason that they're different is that end_time was added after the methods were changed.

from_yaml and from_hash still probably need to be able to deserialize start_date

@avit
Copy link
Collaborator

avit commented Apr 6, 2014

Added IceCube.compatibility to deal with this transition; released in 0.12.0. See UPGRADING file.

@avit avit closed this as completed Apr 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants