-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to impersonate a subuser #634
Comments
@thinkingserious the documentation says:
I notice that In other words, if I want to impersonate a user called "bob", do I need |
@thinkingserious One more question regarding impersonation: the documentation clearly says that the on-behalf-of header does not work with the mail.send API, but I also found a few resources, such as batches, campaigns, teammates, etc. (see below for complete list), where this header is not documented. Is that just an oversight in the documentation or does it mean they don't support impersonation? Here's the list of endpoints where the documentation omits the on-behalf-of header: |
It is my understanding that the on behalf of should be available on all v3 endpoints except mail/send |
Now, having said that, these one's don't have support:
The other items listed support On-Behalf-of |
@ksigler7 @Whatthefoxsays for visibility on possible docs update (see @Jericho's message 3 up from this one) |
@mbernier if subusers can't manage their IPs (which explains why the on-behalf-of header is not supported in the IP Addresses and the IP Pools endpoints), why are they allowed to add/remove an IP to/from warmup? IMHO that's not consistent. |
thanks @mbernier - should be updated now |
@ksigler7 can you let us know what was updated? |
Thanks @ksigler7. I see the changes in the documentation for batches, campaigns, partner settings and IP warmup but I don't notice anything different in the doc for subusers and teammates. These two sections did not mention the on-behalf-of header and, as far as I can tell, they still don't. Anyway, based on the explanation @mbernier gave me a few days ago, I understand these two endpoints are not supposed to support impersonation so I was not expecting any changes. |
@ksigler7 also, I think my original question was overlooked. Is that something you can look into? |
@Jericho to answer your original question, it should be |
@mbernier Feature request: would SendGrid be open to the idea of enhancing If not, is there a workaround that ensures emails are associated with the desired subuser (and count against their monthly quota)? |
@mbernier Just following up on my suggestion from a few months ago. Do you think SendGrid would consider adding the ability to impersonate when sending an email? |
@thinkingserious can you check with @mbernier if he can comment on my feature request? |
In the feedback form, there a section for the business use case. Could you please elaborate on that for me? Thanks! Elmer |
The use case is: being able to send transactional emails (and bulk emails as well) on behalf of another account (which is called a "subuser" in SendGrid's lingo) and ensure these emails are counted against that other account's monthly quota as opposed to being calculated against my monthly quota. I had a long in depth discussion with Devin Chasanoff on this topic back in November last year and also discussed it with Matt Bernier in March 2016. Every time I bring it up I'm told this is a well known feature request that should be looked at and eventually implemented. I'm just trying to formally request this feature. |
Perfect, thanks! |
Hello, |
Hello @ilFusta, I don't have any news on this feature yet, but due to your request I have asked for an update and will respond here when I learn more. Thanks for reaching out! With Best Regards, Elmer |
Thanks @thinkingserious It's ok for me, it just need some more configuration to setup different api keys, but actually you are right, it's more secure and can be better tuned. Thank you. |
I'm curious why SendGrid went to the trouble of allowing us to execute several API calls 'on behalf of', but not this one. If the logic is that it's more secure, then why is it not more secure for the other calls? I just don't understand the lack of consistency. |
HI @Jericho, I believe those other calls were implemented as one-off requests for specific use cases. My guess is that the mail/send endpoint probably warrants additional security considerations and implementing this feature on that endpoint is not as high of priority vs the rest of the items on our backlog. With Best Regards, Elmer |
@thinkingserious the docs state there is a 100 limit on api keys, is that in total for the parent account? If so, how can we send on behalf of subusers if we have more than 100 subusers? Edit: After speaking with SendGrid the limit is per account, so each subuser has it's own 100 limit. |
Has there been any update on this type of feature? Is there anyway to perform requests on behalf of a sub user, or even to simply set headers on a RequestAsync API call? |
@jkerrwilson you can set the request headers in the SendGridClient constructor. I recently had to do this to set the "on-behalf-of" header. |
Closing this issue out as the request to support the Note that backend product teams do not use GitHub to track feature requests. Best to contact support in order to help push the request. |
Please see the Python implementation for an example.
The text was updated successfully, but these errors were encountered: