Skip to content

Commit

Permalink
Fix ClickTracking settings serialization
Browse files Browse the repository at this point in the history
  • Loading branch information
pizzot committed Oct 20, 2016
1 parent 27093d3 commit 74a6ba8
Show file tree
Hide file tree
Showing 2 changed files with 57 additions and 1 deletion.
5 changes: 4 additions & 1 deletion lib/helpers/mail/Mail.php
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,10 @@ public function jsonSerialize()
[
'enable' => $this->getEnable(),
'enable_text' => $this->getEnableText()
]
],
function ($value) {
return $value !== null;
}
);
}
}
Expand Down
53 changes: 53 additions & 0 deletions test/unit/ClickTrackingTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
<?php

/**
* ClickTracking Test. Tests JSON serialization of ClickTracking class.
*
* @author Aleksey Lavrinenko <[email protected]>
* @covers \SendGrid\ClickTracking
*/
class ClickTrackingTest extends \PHPUnit_Framework_TestCase
{
public function testDefaultSerializesToEmptyArray()
{
$clickTracking = new \SendGrid\ClickTracking();

$this->assertEquals([], $clickTracking->jsonSerialize());
}

public function testSerializesTrueValues()
{
$clickTracking = new \SendGrid\ClickTracking();
$clickTracking->setEnable(true);
$clickTracking->setEnableText(true);

$this->assertEquals([
'enable' => true,
'enable_text' => true,
], $clickTracking->jsonSerialize());
}

public function testSerializesFalseValues()
{
$clickTracking = new \SendGrid\ClickTracking();
$clickTracking->setEnable(false);
$clickTracking->setEnableText(false);

$this->assertEquals([
'enable' => false,
'enable_text' => false,
], $clickTracking->jsonSerialize());
}

public function testSerializesVariousValues()
{
$clickTracking = new \SendGrid\ClickTracking();
$clickTracking->setEnable(false);
$clickTracking->setEnableText(true);

$this->assertEquals([
'enable' => false,
'enable_text' => true,
], $clickTracking->jsonSerialize());
}
}

0 comments on commit 74a6ba8

Please sign in to comment.