Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Coding Standards to PSR-2 #317

Closed
pizzot opened this issue Oct 20, 2016 · 2 comments
Closed

Upgrade the Coding Standards to PSR-2 #317

pizzot opened this issue Oct 20, 2016 · 2 comments
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap type: question question directed at the library

Comments

@pizzot
Copy link

pizzot commented Oct 20, 2016

PEAR sounds like something obsolete and the coding standards are very outdated and some even don't make any sense, for instance things like ASCII, ISO-8859-1, 'one line feed after the closing PHP tag' etc..

Since the code in the repo is not follwing PEAR standards very well anyway (I mean it either does or does not - nothing in between), I propose switching to a more modern, sensible and widely used PSR.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap type: question question directed at the library status: help wanted requesting help from the community labels Oct 20, 2016
@thinkingserious
Copy link
Contributor

Hello @okneloper,

We are happy to consider a change, do you have a suggestion? PSR-2?

@pizzot
Copy link
Author

pizzot commented Oct 21, 2016

Yeah, what meant by PSR is PSR 2 which also includes PSR 1. I would expect more people to be happy to code to that standard than to PEAR.

@thinkingserious thinkingserious changed the title Coding Standards Upgrade the Coding Standards to PSR-2 Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap type: question question directed at the library
Projects
None yet
Development

No branches or pull requests

2 participants