Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade sendgrid/php-http-client #295

Merged
merged 5 commits into from
Sep 29, 2016
Merged

Upgrade sendgrid/php-http-client #295

merged 5 commits into from
Sep 29, 2016

Conversation

akeeman
Copy link
Contributor

@akeeman akeeman commented Sep 21, 2016

Version 3.2.0 and above from the sendgrid/php-http-client library use improved autoloading, fixing a problem where \SendGrid\Response cannot be found when using a non-optimized composer installation.
When semantic versioning is applied, it is save to upgrade to newer feature releases.

Version 3.2.0 and above from the sendgrid/php-http-client library use improved autoloading, fixing a problem where \SendGrid\Response cannot be found when using a non-optimized composer installation.
When semantic versioning is applied, it is save to upgrade to newer feature releases.
@akeeman
Copy link
Contributor Author

akeeman commented Sep 21, 2016

I sent the cla to [email protected].

@thinkingserious thinkingserious added status: cla signed type: community enhancement feature request not on Twilio's roadmap labels Sep 22, 2016
@thinkingserious
Copy link
Contributor

Thanks for the pull request @akeeman!

Do you want to try solving the failed tests or would you like us to take this one over?

@akeeman
Copy link
Contributor Author

akeeman commented Sep 22, 2016

As a specific version of the php-http-client is used, it works for now to use reflection properties to check the host, request headers and version of the client.
The client should provide getters for these. I have provided a pr there to fix this. Maybe it's wise to check if that one will be accepted first. Winks to @thinkingserious
It would be nice for the php-http-client to use semantic versioning so the latest bugs fixes and features can be used here too without too much hassle. I opened an issue for that here.

@thinkingserious
Copy link
Contributor

@akeeman,

I have merged in your PR, could you please update this pull request?

Thanks!

@akeeman
Copy link
Contributor Author

akeeman commented Sep 27, 2016

There you go!

You indicated that the php-http-client library should follow semver standards. Therefore I set the php-http-client version back to to "~3.4", instead of "3.4" (note the tilde!).

@thinkingserious thinkingserious merged commit 1165725 into sendgrid:master Sep 29, 2016
thinkingserious added a commit that referenced this pull request May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants