UTF8 force #367
Merged
UTF8 force #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposing a force to UTF8 encoding on set for content value and message subject. If you pass non-UTF8 into the v3 API currently it will error with no reason giving; a "null" response with zero feedback to the caller. My "experience" is I had customer data with awkward encoding which caused a rabbit hole chase to find the core issue. I believe there is a good solid argument that my app should have forced the encoding. I agree with this. However, this fix at the SDK level may save someone else the pain. Also interested in other ways to work around it and open to feedback.
thinkingserious
added
status: code review request
|
Hello @cbschuld, |
|
@thinkingserious - CLA should be on record now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing a force to UTF8 encoding on set for content value and message subject. If you pass non-UTF8 into the v3 API currently it will error with no reason giving; a "null" response with zero feedback to the caller. My "experience" is I had customer data with awkward encoding which caused a rabbit hole chase to find the core issue. I believe there is a good solid argument that my app should have forced the encoding. I agree with this. However, this fix at the SDK level may save someone else the pain. Also interested in other ways to work around it and open to feedback.