Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR1 & PSR2 Conversion #373

Merged
merged 2 commits into from
Apr 4, 2017
Merged

PSR1 & PSR2 Conversion #373

merged 2 commits into from
Apr 4, 2017

Conversation

Braunson
Copy link
Contributor

Related to #319 where the fork was deleted and the PR is an orphan.


Reference issue #317.

Tried to run tests on current master copy in addition to this PR version, kept getting errors referencing Class SendGrid and Class SendGrid\Client not found. I'm going to assume it's related to this #91

- Converted code to PSR1 standards
- Converted code to PSR2 standards
- Updated contributing.me with PSR2 code standards
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Mar 31, 2017
@SendGridDX
Copy link

SendGridDX commented Mar 31, 2017

CLA assistant check
All committers have signed the CLA.

@SendGridDX SendGridDX merged commit 055aa9b into sendgrid:master Apr 4, 2017
@SendGridDX
Copy link

Hello @Braunson,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants