Allow custom queuing strategy for event streams #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality
Adds ability to use a user-defined queuing strategy for
eventStream().Reason for this PR
The default queuing strategy can apparently cause memory issues server-side due to backpressure, even for the most simplest of cases.
Issues tested with code from this blog post.
The internal queue of the
ReadableStreamis never getting fully cleared out, and is steadily consuming more memory with eachsend()call.After adjusting the queuing strategy to
new CountQueuingStartegy({ highWaterMark: 2 }), the memory issues stopped.