Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pid and log files settings #1

Merged
merged 4 commits into from
Mar 12, 2014
Merged

Improve pid and log files settings #1

merged 4 commits into from
Mar 12, 2014

Conversation

jlecour
Copy link
Collaborator

@jlecour jlecour commented Mar 12, 2014

  • when processes > 1 the pid file has its increment before the extension and all pid files have their increment (not just after the first) ;
  • the log file can be configured ;
  • the environment is inferred.

Inspired from sidekiq/sidekiq#1539 by @seuros

jlecour added 2 commits March 12, 2014 18:00
* the pid file has its increment before the extension when processes > 1
* the log file can be configured.
* the environment is inferred.

Inspired from sidekiq/sidekiq#1539
When processes > 1, all pid files have an increment,
not just those after the first.
@jlecour
Copy link
Collaborator Author

jlecour commented Mar 12, 2014

The second commit, about the increment is very opinionated and you're welcome to argue against it.

@jlecour
Copy link
Collaborator Author

jlecour commented Mar 12, 2014

Even with those refactorings, I still have the ghost processes issue. But I don't think it's this recipe's fault. I get a ghost process for processes >= 2 and it's created but a sidekiq bootstrap execution.

seuros added a commit that referenced this pull request Mar 12, 2014
Improve pid and log files settings
@seuros seuros merged commit ea708de into seuros:master Mar 12, 2014
@seuros
Copy link
Owner

seuros commented Mar 12, 2014

I think it because cap2 recipe use nohup instead of -d.

@seuros
Copy link
Owner

seuros commented Mar 12, 2014

I pushed a new branch https://github.com/seuros/capistrano-sidekiq/tree/ghost , can you try it ?

@jlecour
Copy link
Collaborator Author

jlecour commented Mar 12, 2014

That's exactly what I figured at too. I was still having a strange behavior so I didn't send my PR yet.

@seuros
Copy link
Owner

seuros commented Mar 12, 2014

We should change the quiet and stop tasks, it is ugly.

aquarla pushed a commit to aquarla/capistrano-sidekiq that referenced this pull request Oct 11, 2017
Add support role specific configuration values seuros#158
seuros pushed a commit that referenced this pull request Apr 3, 2018
update sidekiq dependency
seuros pushed a commit that referenced this pull request Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants