-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve pid and log files settings #1
Conversation
* the pid file has its increment before the extension when processes > 1 * the log file can be configured. * the environment is inferred. Inspired from sidekiq/sidekiq#1539
When processes > 1, all pid files have an increment, not just those after the first.
The second commit, about the increment is very opinionated and you're welcome to argue against it. |
Even with those refactorings, I still have the ghost processes issue. But I don't think it's this recipe's fault. I get a ghost process for processes >= 2 and it's created but a sidekiq bootstrap execution. |
Improve pid and log files settings
I think it because cap2 recipe use nohup instead of -d. |
I pushed a new branch https://github.com/seuros/capistrano-sidekiq/tree/ghost , can you try it ? |
That's exactly what I figured at too. I was still having a strange behavior so I didn't send my PR yet. |
We should change the quiet and stop tasks, it is ugly. |
Add support role specific configuration values seuros#158
Inspired from sidekiq/sidekiq#1539 by @seuros