-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search pid files in correct directory #12
Conversation
fixes sidekiq:stop and sidekiq:cleanup
pid_file is the absolute path to the pidfile. |
strange. It isn't on my machine:
|
... and the last one answers the question why it isn't |
why do you set it ? remove that line : |
yup. doing that. that helps. sorry to have wasted your time. does this mean these changes here are a bad idea though? the way |
The changes are very good. Could you rebase and stash your commits ? |
will do. |
for_each_process changes into current_dir before yielding pid files this fixes sidekiq:stop when sidekiq_pid is set to a relative path
search pid files in correct directory
Thank you |
thanks 👍 |
this should fix #9, (sidekiq:stop and sidekiq:cleanup)