Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom monit filename #132

Merged
merged 5 commits into from
Apr 3, 2018
Merged

Support custom monit filename #132

merged 5 commits into from
Apr 3, 2018

Conversation

zocoi
Copy link
Contributor

@zocoi zocoi commented Dec 1, 2015

I'm using monit-5.9 and our server config requires a custom path and extension e.g
/usr/local/etc/monit.d/foobar-worker.monitrc instead of *.conf file. I managed to override the custom folder path but not the file name. Hence this PR exists.

Please help reviewing. It has been manually tested.

set :sidekiq_monit_conf_dir, '/usr/local/etc/monit.d'
set :sidekiq_monit_conf_file, 'service-worker.monitrc'
set :monit_bin, '/usr/local/bin/monit'

@zocoi
Copy link
Contributor Author

zocoi commented Dec 1, 2015

ping @seuros

@seuros
Copy link
Owner

seuros commented Dec 2, 2015

This don't take in account multiple processes.

you can overwrite the name with :

https://github.com/seuros/capistrano-sidekiq/blob/master/lib/capistrano/tasks/monit.rake#L95-L97

@zocoi
Copy link
Contributor Author

zocoi commented Dec 2, 2015

There's only one config file uploaded to the host, multiple processes are generated from the template right? By default, the helper method def sidekiq_service_name(index=nil) generate the filename without index so it should not matter here.

Also, the new config would take care of different extension, for example I need *.monitrc instead of *.conf for monit-5.9

@seuros seuros merged commit a5bb5ff into seuros:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants