Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to make some obsolete stuff cleanup in the gem. As far as
capistrano-sneakers
tries to copy common parts from this gem, it will be nice to cleanup here and then copy the code there. It will allow maintainers/contributors to switch between gems much easier.Major notes
capistrano
2 files, because it's support was dropped long time ago. Current gemspec holds dependency version3.9.0
.USR1
) and 5 (TSTP
) version, but current manual signal mode sends only USR1.#background
method.1.0.0
to make people aware about it's stability and maturity. I guess this gem deserved to be called production-ready ^_^monit
template, they should adjust it to usepid_files
variable instead ofprocesses_pids
.Minor notes
I may squash commits after review if you wish to keep it in a single commit.