Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.0.0 #236

Merged
merged 1 commit into from
May 12, 2020
Merged

Release 2.0.0 #236

merged 1 commit into from
May 12, 2020

Conversation

seuros
Copy link
Owner

@seuros seuros commented Jan 16, 2020

closes #233 #234
fixes #228

@seuros seuros mentioned this pull request Jan 16, 2020
Open
dmitry
dmitry reviewed Jan 29, 2020
View reviewed changes
README.md

require 'capistrano/sidekiq'
install_plugin Capistrano::Sidekiq # Default sidekiq tasks
# Then select your service manager
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include monit here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seuros please include monit here.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme is totaly outdated, i will do that once the gem is full working in this branch.

You can open PR against this branch if you can help. I will merge

Tietew
Tietew reviewed Feb 4, 2020
View reviewed changes
lib/capistrano/tasks/systemd.rake Outdated
task :quiet do
on roles fetch(:sidekiq_roles) do |role|
git_plugin.switch_user(role) do
execute :systemctl, "--user", "reload", fetch(:sidekiq_service_unit_name), raise_on_non_zero_exit: false
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"--user" still hardcoded against #228.

@dmitry dmitry mentioned this pull request Apr 21, 2020
Closed
@23tux
Copy link

23tux commented Apr 24, 2020

Is there any news on this PR?

@cupnoodle
Copy link

Anyway we can help on this PR?

@egracens
Copy link

Hi @seuros! Hope you are doing fine! Will you finish this PR?

@seuros
Copy link
Owner Author

seuros commented Apr 29, 2020

@egracens , thank you for the ping.
I totally forgot about it.
Yes. i will now.

@seuros
Copy link
Owner Author

seuros commented Apr 29, 2020

Can you use sudo or i do a user witch to root to install the global systemd service ?

@seuros seuros force-pushed the dev branch 3 times, most recently from 551689e to 6fce5fc Compare April 29, 2020 17:59
dmitry
dmitry suggested changes Apr 29, 2020
View reviewed changes
README.md

require 'capistrano/sidekiq'
install_plugin Capistrano::Sidekiq # Default sidekiq tasks
# Then select your service manager
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seuros please include monit here.

@seuros seuros force-pushed the dev branch 4 times, most recently from 942b84d to 9767f2c Compare April 29, 2020 19:24
@andrepcg
Copy link

andrepcg commented May 7, 2020 •
edited
Loading

Any news? Btw, I'm not sure it is required to have git_plugin = self in the tasks file or not, otherwise it might crash (for upstart)

@JoeDupuis
Copy link

What is missing? Can we help? Version 1.0.2 works great for me with sidekiq 6.0.6 using Systemd.

@andrepcg
Copy link

@JoeDupuis

Bundler could not find compatible versions for gem "sidekiq":
  In snapshot (Gemfile.lock):
    sidekiq (= 6.0.7)

  In Gemfile:
    sidekiq

    capistrano-sidekiq was resolved to 1.0.3, which depends on
      sidekiq (>= 3.4, < 6.0)

@JoeDupuis
Copy link

Version 1.0.3 lock the sidekiq gem to < 6.0, but the 1.0.2 doesn't. And it works fine (using systemd) if you want to upgrade to 6 without waiting for capistrano-sidekiq 2.0.

Just lock capistrano-sidekiq to 1.0.2 and you should be fine.

@23tux
Copy link

23tux commented May 11, 2020 •
edited
Loading

@JoeDupuis thanks for the hint, but when I try to use 1.0.2 I get this error during sidekiq:start

      01 invalid option: --index
      01 /var/www/app/shared/bundle/ruby/2.6.0/gems/sidekiq-6.0.7/lib/sidekiq/cli.rb:291:in `parse_options'
      01 /var/www/app/shared/bundle/ruby/2.6.0/gems/sidekiq-6.0.7/lib/sidekiq/cli.rb:205:in `setup_options'
      01 /var/www/app/shared/bundle/ruby/2.6.0/gems/sidekiq-6.0.7/lib/sidekiq/cli.rb:24:in `parse'
      01 /var/www/app/shared/bundle/ruby/2.6.0/gems/sidekiq-6.0.7/bin/sidekiq:27:in `<top (required)>'
      01 /var/www/app/shared/bundle/ruby/2.6.0/bin/sidekiq:23:in `load'
      01 /var/www/app/shared/bundle/ruby/2.6.0/bin/sidekiq:23:in `<top (required)>'

@seuros
Copy link
Owner Author

seuros commented May 11, 2020

@23tux , master will work for you.
I'm going to test it with a centos instance(i tested only in ubuntu) and release the version

@seuros
Copy link
Owner Author

seuros commented May 11, 2020

Sorry, i meant this branch.

@seuros seuros force-pushed the dev branch 2 times, most recently from 99f9fc0 to 1ff9fa0 Compare May 12, 2020 23:13
@seuros seuros merged commit bb661da into master May 12, 2020
@bayevels
Copy link

I tested it on a Debian 10 Server worked perfectly Thanks :)

@seuros seuros deleted the dev branch May 13, 2020 18:08
@seuros
Copy link
Owner Author

seuros commented May 13, 2020

Thanks for the feedback.

I'm releasing 2.0.0.beta1 .

I will test in other OSes.

And we readd features dropped such as multi processes support.

@ivanovv
Copy link

ivanovv commented Apr 4, 2021

I'm a bit late for the party with this question, but what was the reason to drop sidekiq 5 support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tietew Tietew Tietew left review comments

@dmitry dmitry dmitry requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using systemd, run sidekiq as a system service rather than "user service"
10 participants
@seuros @23tux @cupnoodle @egracens @andrepcg @JoeDupuis @bayevels @ivanovv @dmitry @Tietew