-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various systemd improvements - Multiple Process Support, Per Process Config, Proper Restarts with timeout and more #279
Conversation
…e options for systemd
* 'master' of github.com:farnsworth/capistrano-sidekiq: added sidekiq_service_templates_path to manage custom systemd templates
* 'master' of github.com:ayn/capistrano-sidekiq: Add support for sidekiq_config, sidekiq_concurrency, and sidekiq_queue options for systemd
Updated systemd template using official example from mperham. Updated readme with commmon undocumented settings and made a note about seeing where more are.
…ript that waits till all workers are done or 30 seconds.
…rt and created symlinked config files for each process. Also improved restart to handle each process and fixed errors on log lines.
* per_process_config: Refactored per process config to use systemds built in varaible support and created symlinked config files for each process. Also improved restart to handle each process and fixed errors on log lines. Per process config v1
I realized we needed per process configuration support. I'm not sure for certain if this was a thing in the past, but it looks like it has been requested and existed on some other forks. You can now set an array for |
@seuros have you had a chance to look at this? |
Excellent. Let merge to master and have some time to test it. |
This merge creeped back some bugs that were already fixed (ex: PR #272) |
I've tried to cleanup the overall systemd support in this repository. I've merged in a few other contributors PRs (#262 and #265) since they both were of use to me at some point.
Here are the major changes
set :sidekiq_processes, 3
which was previously removed I guess. This uses systemd's built in functionality to support multiple processes. The service file gets named[email protected]
and then processes are managed usingsystemctl [command] sidekiq@{1..2}
.systemctl kill -s TSTP sidekiq@{1..2}
)