Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented ability to split sidekiq_roles by count of sidekiq-processes #45

Merged
merged 5 commits into from
Apr 5, 2015

Conversation

alexyakubenko
Copy link
Contributor

Now we can customize how many processes capistrano has to run on each server.

set :sidekiq_role, [:sidekiq, :sidekiq_small, :sidekiq_big]

set :sidekiq_small_processes, 2
set :sidekiq_big_processes, 4

role :sidekiq, 'sidekiq.example.com'
role :sidekiq_small, 'sidekiq_small.example.com'
role :sidekiq_big, 'sidekiq_big.example.com'

It was very helpfull for me because we use different AWS-S3 instancess for sidekiq. I hope it will be helpfull for other developers.

@seuros
Copy link
Owner

seuros commented Sep 16, 2014

Nice! Can you update the Readme with an example ?

@alexyakubenko
Copy link
Contributor Author

Yes, sure! I did it.

@seuros
Copy link
Owner

seuros commented Sep 17, 2014

I just noticed that only for capistrano2. We need to support cap 3

@alexyakubenko
Copy link
Contributor Author

Ok. I'll implement same logic for capistrano 3.

@ksiomelo
Copy link

+1

@sahin
Copy link

sahin commented Nov 23, 2014

any update on this PR?

@alexyakubenko
Copy link
Contributor Author

Hey, guys. I've implemented support of cap3.
Do we need to support custom sidekiq_options_per_process for each sidekiq-role?
I think it may be helpfull to have an ability to configure :sidekiq_small_options_per_process and :sidekiq_big_options_per_process for example.

@seuros
Copy link
Owner

seuros commented Mar 31, 2015

Great job. Could you add an entry to the changelog ?

@Saicheg
Copy link
Contributor

Saicheg commented Mar 31, 2015

+1 fot this PR

@alexyakubenko
Copy link
Contributor Author

Hey, guys. Do you have any update about my PR?

seuros added a commit that referenced this pull request Apr 5, 2015
implemented ability to split sidekiq_roles by count of sidekiq-processes
@seuros seuros merged commit e21647c into seuros:master Apr 5, 2015
@ivanovv
Copy link

ivanovv commented Jun 25, 2015

+1 for

I think it may be helpful to have an ability to configure :sidekiq_small_options_per_process and :sidekiq_big_options_per_process for example.

Currently my assumption is if I have

set :sidekiq_options_per_process, ["--queue default --queue import", "--queue default --queue import", "--queue default --queue import", "--queue csv"]
set :sidekiq_role, [:sidekiq_small, :sidekiq_big]
set :sidekiq_small_processes, 1
set :sidekiq_big_processes, 4

then the small sidekiq will use the first entry from sidekiq_options_per_process, and the big sidekiq will use all options from sidekiq_options_per_process. Is it correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants