[BUG] Unloader Machine both ice and ore

[Ziiro]

Round ID:

Testmerges:

Reproduction:

Slide an ore box with ice and other ores into an Unloader Machine's "Unload" spot. It will unload the ice.

If you try the other way, the Ice Unloader does not unload ore. Only ice. This should probably be fully separated into "Ore Unloader" and "Ice Unloader" that do not intersect.

Compare the code:

Unloader

Shiptest/code/modules/mining/machine_unloading.dm

Lines 14 to 21 in 8b97a24

	/obj/machinery/mineral/unloading_machine/pickup_item(datum/source, atom/movable/target, atom/oldLoc)
	if(istype(target, /obj/structure/ore_box))
	var/obj/structure/ore_box/box = target
	for(var/obj/item/stack/ore/O in box)
	unload_mineral(O)
	else if(istype(target, /obj/item/stack/ore))
	var/obj/item/stack/ore/O = target
	unload_mineral(O)

Ice Machine:

Shiptest/code/game/machinery/outpost_electrolyzer.dm

Lines 22 to 29 in 8b97a24

	/obj/machinery/mineral/electrolyzer_unloader/pickup_item(datum/source, atom/movable/target, atom/oldLoc)
	if(istype(target, /obj/structure/ore_box))
	var/obj/structure/ore_box/box = target
	for(var/obj/item/stack/ore/ice/chunk in box)
	unload_mineral(chunk)
	else if(istype(target, /obj/item/stack/ore/ice))
	var/obj/item/stack/ore/chunk = target
	unload_mineral(chunk)