Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move seccomp profile definition to container securityContext #1806

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Move seccomp profile definition to container securityContext #1806

merged 1 commit into from
Feb 21, 2025

Conversation

SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 commented Feb 21, 2025 •
edited
Loading

Changes

Since Kubernetes 1.31, seccomp annotations are ignored. Therefore finally moving them to the container security context.

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

Release Notes

The BuildKit sample build strategy defines the seccomp profile now in the security context instead of the - since k8s 1.31 - unsupported annotation

@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.15.0 milestone Feb 21, 2025
@openshift-ci openshift-ci bot added the release-note Label for when a PR has specified a release note label Feb 21, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 21, 2025
@SaschaSchwarze0 SaschaSchwarze0 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 21, 2025
qu1queee
qu1queee approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@qu1queee qu1queee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qu1queee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 8621bb7 into shipwright-io:main Feb 21, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qu1queee qu1queee qu1queee approved these changes

Assignees

@qu1queee qu1queee

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Label for when a PR has specified a release note size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Shipwright Overview
Status: Done
Milestone
release-v0.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SaschaSchwarze0 @qu1queee