Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

July 19th, 2021 Community Meeting #17

Closed
qu1queee opened this issue Jul 13, 2021 · 3 comments
Closed

July 19th, 2021 Community Meeting #17

qu1queee opened this issue Jul 13, 2021 · 3 comments

Comments

@qu1queee
Copy link
Contributor

  • Please add a topic in this thread and add a link to the Github issue associated with the topic.
  • Please make sure you give folks enough time to review/discuss the topic offline on Github before coming into the meeting
  • (optional) Paste the image of an animal 😸
@qu1queee
Copy link
Contributor Author

here a collie! here a collie, be happy

@adambkaplan
Copy link
Member

GitHub Actions: accessing secrets/credentials in pull requests

@adambkaplan
Copy link
Member

Meeting minutes:

  • Windows Container Builds
    • Full chain of Shipwright BuildRuns probably need to support Windows - Tekton, our injected code (git clone), the build strategy itself
    • BuildRuns need to be able to select Windows nodes
    • Alternatives - perhaps try with Tekton to launch a Windows instance in KubeVirt?
    • If this can be done in a single Tekton Task, then there may be room to convert it into a build strategy.
  • Secrets/credentials in PRs
    • PRs run on the user's fork, therefore can't access secrets on the shipwright-io repositories
    • We can run these tests when code merges to the main branch.
    • CI tests should be configured to skip tests if the required credential is not present (environment variable is empty).
    • Using the pull_request_target context was evaluated, considered too dangerous for PR tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants