Update deps #422
Merged
Update deps #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cargo deny was failing on hsivonen/encoding_rs#75 so I added an exception until its fixed upstream |
conorbros
approved these changes
Dec 13, 2021
benbromhead
approved these changes
Dec 15, 2021
benbromhead
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cassandra_codec changes are a lot easier to review if you set the diff to ignore whitespace.
While making these changes I noticed that we were completely ignoring failure to parse the csql so I added the bare minimum handling (just logging the failure)
Not sure how best to untokenize the assignment id but
assignment.id.iter().map(|x| &x.value).join(".")is my best guess.I dont think its worth spending too much time thinking about, we probably need to completely replace this stuff with a cassandra specific parser anyway.