Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches a couple lines in the brake functionality of the hwp-supervisor agent.
Description
In the logic of the brake function I switched the order of lines so that the setting of the voltage occurs after switching the pmx to direct voltage control.
Motivation and Context
Currently the brake function of the hwp-supervisor has an argument
brake_voltage
which does not work because of a bug. To brake, the hwp uses a PMX power supply. This power supply can be configured to use an external voltage to control the output. This configuration is enabled during rotation and takes a PID feedback as an input. To brake however, this configuration is disabled and a static voltage is used instead. The issue is that while the external voltage configuration is enabled, commands to change the static voltage are ignored. Thus as the code was previously, commands to change the brake voltage would be ignored, and the PMX would simply use the last commanded static voltage value as the brake voltage (for satp1 this was 31V and for satp3 this was 10V).How Has This Been Tested?
I tested these changes with the satp2 hwp. After implementing the changes the brake issue was resolved
Types of changes
Checklist: