Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HWP supervisor agent brake bugfix #720

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

bbixler500
Copy link
Contributor

This PR switches a couple lines in the brake functionality of the hwp-supervisor agent.

Description

In the logic of the brake function I switched the order of lines so that the setting of the voltage occurs after switching the pmx to direct voltage control.

Motivation and Context

Currently the brake function of the hwp-supervisor has an argument brake_voltage which does not work because of a bug. To brake, the hwp uses a PMX power supply. This power supply can be configured to use an external voltage to control the output. This configuration is enabled during rotation and takes a PID feedback as an input. To brake however, this configuration is disabled and a static voltage is used instead. The issue is that while the external voltage configuration is enabled, commands to change the static voltage are ignored. Thus as the code was previously, commands to change the brake voltage would be ignored, and the PMX would simply use the last commanded static voltage value as the brake voltage (for satp1 this was 31V and for satp3 this was 10V).

How Has This Been Tested?

I tested these changes with the satp2 hwp. After implementing the changes the brake issue was resolved

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@bbixler500 bbixler500 requested a review from jlashner August 12, 2024 15:51
@ykyohei ykyohei self-requested a review August 13, 2024 12:03
Copy link
Contributor

@ykyohei ykyohei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Collaborator

@jlashner jlashner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, this looks good to me!

@BrianJKoopman BrianJKoopman merged commit 9da4ece into main Aug 13, 2024
5 checks passed
@BrianJKoopman BrianJKoopman deleted the hwp-supervisor-brake-bugfix branch August 13, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants