Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HWP supervisor iboot indexing bugfix #722

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

bbixler500
Copy link
Contributor

Changes how the supervisor indexes iboot outlets when querying their state. This change only effects how the outlet states are reported in the monitor session data (actual functions using the iboot outlets are uneffected)

Description

Subtracts one from the supplied outlet number, as the iboot outlets are indexed 0-7 while the outlet input argument is indexed 1-8.

Motivation and Context

This fix ensures that the session data is accurate. Additionally, the supervisor agent would previously crash with an index error whenever trying to use outlet 8 (which is the case for the satp2 gripper power supplies)

How Has This Been Tested?

I tested this fix with the satp2 hwp.
Outlet states:
iboot outlet state

Before change:
supervisor old outlet index

After change:
supervisor new outlet index

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@bbixler500 bbixler500 requested a review from jlashner August 13, 2024 17:20
Copy link
Collaborator

@jlashner jlashner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks bryce!

@BrianJKoopman BrianJKoopman added the bug Something isn't working label Aug 13, 2024
@BrianJKoopman BrianJKoopman merged commit 168ca93 into main Aug 13, 2024
4 checks passed
@BrianJKoopman BrianJKoopman deleted the hwp-supervisor-iboot-bugfix branch August 13, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants