Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix of wiregrid_actuator/Dockerfile for Ubuntu update #759

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

sadachi5
Copy link
Contributor

Description

The socs/docker/wiregrid_actuator/Dockerfile was changed in this PR to make it compatible with the Ubuntu 22.

Motivation and Context

The previous wiregrid_actuator/Dockerfile was incompatible with the recent OCS version, which is based on Ubuntu 22, because the installation method for the actuator controller libraries (gclib, gcapsd) was changed from Ubuntu 20.

How Has This Been Tested?

The connection test to the actuator controller has been done at Kyoto.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and for testing! Two small suggestions to reduce the warnings during build.

&& python3 setup.py install
&& cp /usr/share/gclib/src/wrappers/python/* . \
&& cp /usr/share/gclib/doc/examples/python/* . \
&& python3 setup.py install \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's in the upstream instructions, but direct invocation of setup.py like this is deprecated. Can we change this line to python3 -m pip install . \ instead?

I was able to build successfully using this.

Previous build:

/opt/venv/lib/python3.10/site-packages/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWa
rning: setup.py install is deprecated.
!!

        ********************************************************************************
        Please avoid running ``setup.py`` directly.
        Instead, use pypa/build, pypa/installer or other
        standards-based tools.

        See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
        ********************************************************************************

!!
  self.initialize_options()
/opt/venv/lib/python3.10/site-packages/setuptools/_distutils/cmd.py:66: EasyInstallDeprecationW
arning: easy_install command is deprecated.
!!

        ********************************************************************************
        Please avoid running ``setup.py`` and ``easy_install``.
        Instead, use pypa/build, pypa/installer or other
        standards-based tools.

        See https://github.com/pypa/setuptools/issues/917 for details.
        ********************************************************************************

!!
  self.initialize_options()
ERROR setuptools_scm._file_finders.git listing git files failed - pretending there aren't any
zip_safe flag not set; analyzing archive contents...
gclib location: /home/ocs/gclib.py

New build:

Processing /home/ocs
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'done'
Building wheels for collected packages: gclib
  Building wheel for gclib (setup.py): started
  Building wheel for gclib (setup.py): finished with status 'done'
  Created wheel for gclib: filename=gclib-1.0-py3-none-any.whl size=5509 sha256=a5dd87761922a01
d76cf616ca1e2440c5f2f8d6ac9ffddaacc0ca0f68082bc6e
  Stored in directory: /tmp/pip-ephem-wheel-cache-mo6q0wb9/wheels/4a/c9/f4/70900c0ce2d621b50abb
09a7fa008c78c8e367e7453fd3a63c
Successfully built gclib
Installing collected packages: gclib
Successfully installed gclib-1.0
gclib location: /home/ocs/gclib.py

@sadachi5
Copy link
Contributor Author

@BrianJKoopman I updated the Dockerfile as you suggested. Please check it.

@BrianJKoopman BrianJKoopman self-requested a review September 27, 2024 02:42
Copy link
Member

@BrianJKoopman BrianJKoopman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@BrianJKoopman BrianJKoopman merged commit 5dcf1a7 into main Sep 27, 2024
5 checks passed
@BrianJKoopman BrianJKoopman deleted the sadachi5/fix_wiregrid_actuator branch September 27, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants