Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make key rank estimation bin size tuning smarter. #99

Open
cassiersg opened this issue Apr 4, 2023 · 0 comments
Open

Make key rank estimation bin size tuning smarter. #99

cassiersg opened this issue Apr 4, 2023 · 0 comments

Comments

@cassiersg
Copy link
Contributor

rank_accuracy has the surprising behavior of being sometimes very expensive even when there are few candidates. This happens when many keys have the exact same probability, such that the requested accuracy cannot be reached, and the algorithm reduces bin size until it reaches the max number of bins.

We should:

  • have a way to stop reducing bin size early, when it is clear that reducing it won't improve our rank bounds,
  • have a default max_nb_bin=None that raises an exception if the desired accuracy cannot be reached within a default bound on the number of bin. That would make the cost more explicit to the user (who can still remove the exception the setting max_nb_bin, and the exception could print the bounds it got.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant