Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation branch name #400

Closed
TiagoDanin opened this issue May 4, 2019 · 1 comment
Closed

Validation branch name #400

TiagoDanin opened this issue May 4, 2019 · 1 comment

Comments

@TiagoDanin
Copy link
Contributor

Description

Problem with Regex

np/source/git-util.js

Line 24 in d4bf883

return /^# branch\.upstream [\w\-/]+$/m.test(stdout);

Does not work with a branch named dev.1.0.0

Refs:

Steps to reproduce

  1. git checkout -b dev.1.0.0
  2. np --any-branch major
  3. image

Expected behavior

await git.hasUpstream() return true

Environment

np - 5.0.1
Node.js - 9.9.0
Yarn - 1.15.2
Git - 2.16.2
OS - 4.14.52-1-MANJARO
@TiagoDanin TiagoDanin mentioned this issue May 4, 2019
Closed
@itaisteinherz
Copy link
Collaborator

See #397 and sequelize/sequelize-typescript#602 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept upstream branch name starting with text TiagoDanin-Forks/np
2 participants
@TiagoDanin @itaisteinherz