Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty files or .npmignore warning on private package #469

Closed
EdJoPaTo opened this issue Nov 20, 2019 · 1 comment · Fixed by #472
Closed

Empty files or .npmignore warning on private package #469

EdJoPaTo opened this issue Nov 20, 2019 · 1 comment · Fixed by #472
Labels
bug help wanted

Comments

@EdJoPaTo
Copy link

Description

In a private repo that does not get published to npm the warning about empty files or .npmignore is shown (see #411)

Steps to reproduce

  1. set "private": true in package.json
  2. publish

Expected behavior

No warning is displayed

Environment

np - 5.1.3
Node.js - 13.1.0
npm - 6.13.1
Git - 2.24.0
OS - macOS 10.15.1
@sindresorhus
Copy link
Owner

Yes, we should not display the warning in that case. PR welcome.

@chinesedfan chinesedfan mentioned this issue Nov 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
2 participants
@sindresorhus @EdJoPaTo