Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure dependencies are compatible with the supported Node.js version #480

Closed
sindresorhus opened this issue Dec 23, 2019 · 0 comments · Fixed by #481
Closed

Ensure dependencies are compatible with the supported Node.js version #480

sindresorhus opened this issue Dec 23, 2019 · 0 comments · Fixed by #481
Labels
enhancement help wanted

Comments

@sindresorhus
Copy link
Owner

npm doesn't enforce the engine field of dependencies. This caused sindresorhus/eslint-plugin-unicorn#481.

When np reinstalls the dependencies, I think we should run npm install with the environment variable npm_config_engine-strict=true to make it validate the engine field.

https://docs.npmjs.com/misc/config#engine-strict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce matching engines on npm install sholladay/np
1 participant
@sindresorhus