-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --no-verify option to git push #299
feat: add --no-verify option to git push #299
Conversation
Hi @harryparkdotio, sorry for not commenting sooner. This sounds like a great addition to @sindresorhus Do you have any additional thoughts on this? |
Not sure it’s a good behavior to skip Git hooks by default. Users could have other important checks than tests in their hooks. If we do this, it should be opt-in. |
Of course - this PR adds an opt-in flag to |
Is it possible to get this merged? If so, is there anything I can do to help? I see the source branch was deleted, I can put a new PR in if wanted. |
@chrisblossom Feel free to do so 👍🏻 |
Any reason this was closed? I'd love to see this feature added |
Yeah, it kind of sucks having to open a terminal to push because of a broken git hook. |
I also need this feature. I'm using Husky for pre-commit hooks. But because Husky is installed as a DEV dependency, and as part of my publish I prune all DEV dependencies in the |
skip git hooks when pushing tags
use case
I have git hooks setup to run tests before pushing
I use np to publish
np runs tests before pushing
problem
tests are run twice
tests are run twice, first by np, second by git push hooks