Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#348 Scheduled reminders should notify the user who requested them #349

Merged
merged 3 commits into from
Jun 13, 2018
Merged

#348 Scheduled reminders should notify the user who requested them #349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d418c86
scheduled reminders should notify the user who requested them
unicolet May 2, 2018
dd5c461
credit
unicolet Jun 6, 2018
bdd2e6b
Merge branch 'master' into issue_348_notify_for_remind
skoczen Jun 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,5 @@ TaunoTinits, https://github.com/TaunoTinits
ostracon, https://github.com/ostracon
mattcl, https://github.com/mattcl
Boris Peterbarg, https://github.com/reist
unicolet, https://github.com/unicolet

4 changes: 2 additions & 2 deletions will/plugins/productivity/remind.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def remind_me_at(self, message, reminder_text=None, remind_time=None, to_string=
"reminder_text": reminder_text,
"to_string": formatted_to_string,
}
self.schedule_say(formatted_reminder_text, parsed_time, message=message)
self.schedule_say(formatted_reminder_text, parsed_time, message=message, notify=True)
self.say("%(reminder_text)s %(natural_datetime)s. Got it." % locals(), message=message)

@respond_to("(?:can|will you )?remind (?P<reminder_recipient>(?!me).*?)(?P<to_string> to>) ?(?P<reminder_text>.*?) (at|on|in) (?P<remind_time>.*)?\??")
Expand All @@ -39,5 +39,5 @@ def remind_somebody_at(self, message, reminder_recipient=None, reminder_text=Non
"to_string": formatted_to_string,
}

self.schedule_say(formatted_reminder_text, parsed_time, message=message)
self.schedule_say(formatted_reminder_text, parsed_time, message=message, notify=True)
self.say("%(reminder_text)s %(natural_datetime)s. Got it." % locals(), message=message)