Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict channel will will respond to in Slack #352

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Restrict channel will will respond to in Slack #352

wants to merge 1 commit into from

Conversation

Ashex
Copy link
Collaborator

@Ashex Ashex commented May 17, 2018

This is a half decent implementation of the hipchat rooms restriction. This works by checking the channel a message from the RTM stream is coming from, it is discarded if it does not come from an allowed list.

I believe this also reduces the processing load from handling all the messages.

@skoczen
Copy link
Owner

skoczen commented Jun 6, 2018

So, I like the efficiency idea behind this - but since slack allows adhoc joins (and people seem to be using them), I'm not sure it makes sense to explicitly restrict Will's ability to respond to ROOMS.

That said, this certainly should be documented a whole lot better.

@Ashex
Copy link
Collaborator Author

Ashex commented Jun 6, 2018

I think workspace tokens will make it a lot easier to manage as the permission of scope can be locked down. Currently apps can be added to any channel and we have no control over that, the static channel ACL is simply my solution.

My other idea was to maintain this list inside redis so that an empowered individual (command locked down with user acl) could update the room restriction on the fly.

@Ashex
Copy link
Collaborator Author

Ashex commented Jun 21, 2018

Hi @skoczen Let me know what changes you'd like to see and I'll implement them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants