Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not support dark mode on iOS 13 #424

Closed
koust opened this issue Sep 23, 2019 · 16 comments · Fixed by #421
Closed

not support dark mode on iOS 13 #424

koust opened this issue Sep 23, 2019 · 16 comments · Fixed by #421

Comments

@koust
Copy link

koust commented Sep 23, 2019

Hello everyone ,

I updated all my devices and my applications for iOS 13.
I work only light content mode for my application. "Actionsheetpicker" does not support if my phone is in dark mode

can u help with this?

@praveenislive
Copy link

@skywinder Please help, Even for me facing the same issue.

@koust
Copy link
Author

koust commented Sep 24, 2019

@Praveeeenn

you should be use this pod.

pod 'ActionSheetPicker-3.0', :git => 'https://github.com/arnoldxt/ActionSheetPicker-3.0', :commit => 'ad21f8c8908665ee68623d4fee6c26baaa4cb0dd'

@huynguyencong
Copy link

@Praveeeenn

you should be use this pod.

pod 'ActionSheetPicker-3.0', :git => 'https://github.com/arnoldxt/ActionSheetPicker-3.0', :commit => 'ad21f8c8908665ee68623d4fee6c26baaa4cb0dd'

Thank you. It work for me. I think you can create a pull request to this repo.

@blackturtle2
Copy link

I have developed as below.

if #available(iOS 13.0, *) {
            picker?.toolbarButtonsColor = .label
            picker?.pickerBackgroundColor = .systemGray6
            picker?.toolbarBackgroundColor = .systemGray6
        }

@koust
Copy link
Author

koust commented Sep 29, 2019

@blackturtle2 thanks for another solution

@grehce
Copy link

grehce commented Oct 8, 2019

I have developed as below.

if #available(iOS 13.0, *) {
            picker?.toolbarButtonsColor = .label
            picker?.pickerBackgroundColor = .systemGray6
            picker?.toolbarBackgroundColor = .systemGray6
        }

Thoughts on where I can add the above in an @objc func?

  @objc func alarmButtonTapped(_ sender: UIButton) {
       var components = DateComponents()
       components.year = 200
       let maxDate = Calendar.current.date(byAdding: components, to: Date())        
       let _ = ActionSheetDatePicker.show(withTitle: "Select Alarm", datePickerMode: >UIDatePicker.Mode.dateAndTime, selectedDate: Date(), minimumDate: Date(), maximumDate: maxDate, doneBlock: { (picker, value, index) in
           sender.setTitle((value as! Date).toString(withFormat: "E, MM/dd/yy, h:mm a"), for: .normal)
           self.alarmText = (value as! Date).toString(withFormat: "E, MM/dd/yy, h:mm a")           
           return
       }, cancel: { ActionStringCancelBlock in return
       }, origin: sender.superview)
   }

@koust
Copy link
Author

koust commented Oct 10, 2019

@grehce please, can you check commit? because it is same solution.

@KestrelSystems
Copy link

This did not work for me. Since I only use a white theme I could overide by adding a key in Info.plist

@koust
Copy link
Author

koust commented Oct 14, 2019

Which did you try them? @KestrelSystems

@nitinumaretiya123
Copy link

@Praveeeenn

you should be use this pod.

pod 'ActionSheetPicker-3.0', :git => 'https://github.com/arnoldxt/ActionSheetPicker-3.0', :commit => 'ad21f8c8908665ee68623d4fee6c26baaa4cb0dd'

still not working in iOS 13

@koust
Copy link
Author

koust commented Oct 22, 2019

@Praveeeenn
you should be use this pod.
pod 'ActionSheetPicker-3.0', :git => 'https://github.com/arnoldxt/ActionSheetPicker-3.0', :commit => 'ad21f8c8908665ee68623d4fee6c26baaa4cb0dd'

still not working in iOS 13

Can you check pod version? because I'm using as see in the example.
Thanks

@skywinder
Copy link
Owner

Hey, guys. I’m super busy with other projects. If someone knows how to fix it: please make a PR. I would very appreciate for your help! 🙌
Ps
@huynguyencong did you found a solution?

@skywinder
Copy link
Owner

Looks like #421 should fix this.

@logeshvijayan
Copy link

@koust How did you override the value in plist.I also have a light background for Picker view but I couldn't able to fix it using picker text attributes

@koust
Copy link
Author

koust commented Jul 7, 2020

@logeshvijayan I use pod version directly and its working. Do u own the last version?

@logeshvijayan
Copy link

logeshvijayan commented Jul 8, 2020

@koust So this is my case.My Application has a dark background by default and the overall label colour was set to white.My picker view has a white background and my label colour needs to set in Black.So I need to override the white colour when the picker view is called.(I use latest swift)

I tried to update my pods to the latest version and set picker attributes but nothing worked.What do you mean by using the pod version directly.?

Thanks in Advance for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants