Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDE autocomplete support #103

Closed
rugleb opened this issue Sep 20, 2019 · 4 comments · Fixed by #104
Closed

IDE autocomplete support #103

rugleb opened this issue Sep 20, 2019 · 4 comments · Fixed by #104
Assignees
@sloria
Labels
enhancement

Comments

@rugleb
Copy link

rugleb commented Sep 20, 2019

HI!
Thanks for the package, looks amazing, but what about IDE autocomplete / IntelliSense / hints?
The IDE (I'm using PyCharm) does not prompt existing methods of the Env class instance (see picture below).

Screenshot from 2019-09-20 11-15-20

For me, this is an important drawback of this package.
Will it be decided?
Thanks!
@sloria
Copy link
Owner

sloria commented Sep 21, 2019

This should be possible with a bit of code reorganization. I'll look into it when I have some time.

@sloria sloria self-assigned this Sep 21, 2019
@rugleb
Copy link
Author

rugleb commented Sep 21, 2019

@sloria
Super! I'm waiting.

sloria added a commit that referenced this issue Sep 21, 2019
@sloria
Make default parser methods bound methods
d067bae 
In order to fix static analysis #103.

Side effect: add_parser will error if called with a name that
conflicts with a default parser name.
@sloria sloria mentioned this issue Sep 21, 2019
Merged
sloria added a commit that referenced this issue Sep 22, 2019
@sloria
Make default parser methods bound methods (#104)
8dd86d4 
* Make default parser methods bound methods

In order to fix static analysis #103.

Side effect: add_parser will error if called with a name that
conflicts with a default parser name.

* Rename __parser_map__ to __custom_parsers__
@sloria
Copy link
Owner

sloria commented Sep 22, 2019

This should be implemented in 6.0.0. Please give it a try!

@btx
Copy link

btx commented Dec 15, 2019 •
edited
Loading

It works, thanks. I had to annotate the type explicitly in PyCharm.

env = Env()  # type: Env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sloria sloria

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make default parser methods bound methods sloria/environs
3 participants
@btx @sloria @rugleb