Make BehaviorVersion as future-proof as the documentation and RFC specify #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cify Fixes aws-sdk-rust#1111 This is technically a breaking change but since this was released recently and it's documented that this API shouldn't be used, better now than later.
Ten0
force-pushed
the
behavior_version_private_construction
branch
from
38c2ccc to
de97189
Compare
|
Hi @Ten0, thank you for catching this and contributing the fix! Will get that merged once the PR has passed CI. |
ysaito1001
approved these changes
Mar 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes aws-sdk-rust#1111
This is technically a breaking change but since this was released recently and it's documented that this API shouldn't be used, this can probably be considered a bug, which is better fixed now than later.