Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC30: serde support for error metadata #2637

Closed

Conversation

thomas-k-cameron
Copy link
Contributor

@thomas-k-cameron thomas-k-cameron commented Apr 26, 2023

Motivation and Context

This PR implements serde support for ErrorMetaData.

Description

Serde is implemented behind a feature gate.
This PR do not introduce breaking changes.

Prerequisite PRs

You can reduce the diff if you merge them first.

Parent PR

This PR is listed as one of prerequisite PRs on this PR.

Testing

  1. It checks whether serialized/de-Serialized results are the same.
  2. Checks whether it can de-serialization of JSON file produces an expected result.

Checklist

  • I have updated CHANGELOG.next.toml if I made changes to the smithy-rs codegen or runtime crates
  • I have updated CHANGELOG.next.toml if I made changes to the AWS SDK, generated SDK code, or SDK runtime crates

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@thomas-k-cameron thomas-k-cameron mentioned this pull request Apr 26, 2023
2 tasks
@thomas-k-cameron thomas-k-cameron marked this pull request as ready for review April 26, 2023 11:15
@thomas-k-cameron thomas-k-cameron requested review from a team as code owners April 26, 2023 11:15
@jdisanti
Copy link
Collaborator

Can you update the PR description to say why ErrorMetadata needs ser/de support?

@thomas-k-cameron
Copy link
Contributor Author

Can you update the PR description to say why ErrorMetadata needs ser/de support?

Sorry, I realized that there was a mistake in my implementation.

So, I added serde to ErrorMetadata because it the compiler was complaining to me.
I assumed that some input/output type was using ErrorMetaData, but I realized that it was because I was mistakenly adding serde traits to ErrorType.

I'm closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants