Assorted code clean-up for event stream with RPC-bound protocols #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
aajtodd
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
One thing not in this PR that we might want to cleanup is not having to maintain this.
This most likely belongs on the Protocol interface or possibly the HttpBindingResolver.
It may be fine for now but if a customer brings a new protocol they have no way to do this without modifying smithy-rs (and of course if we implement a new RPC protocol we have to remember to update this).
ysaito1001
added a commit
that referenced
this pull request
Feb 21, 2025
This commit addresses #4023 (review)
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
ysaito1001
merged commit 1964098
into
ysaito/support-event-stream-for-rpc-bound-protocols
44 of 45 checks passed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is the final PR in the series adding support for event streaming with RPC-bound protocols. It primarily focuses on addressing code cleanup tasks that were intentionally left in the previous two PRs.
Description
The code clean-up tasks include
DisableStalledStreamProtectionto disable stalled stream protection from at the top level ofClientCodegenVisitoracross the models, eliminating the need for individual service-specific codegen decorators just to disable stalled stream protection.eventStreamAllowList.TODO(EventStream)for RPC protocols.send).Testing
DisableStalledStreamProtectionTestBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.